refactor(eva): registry and expose profile selection #121
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the evaluation system to use a registry-based architecture with profile support. It introduces a new engine and registry system that allows checks to be registered and organized into profiles (basic, extended, additional), replacing the previous hard-coded execution flow.
Key changes:
- Introduced
engine.goandregistry.gofor profile-based evaluation - Added
categories.goto define check categories with metadata - Converted all evaluation checks to register via
init()functions - Updated CLI to support
--profile=<name>flag - Removed deprecated
auto-escapefunctionality
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/evaluate/engine.go | New engine implementing profile-based check execution with Context and CheckFunc abstractions |
| pkg/evaluate/registry.go | New registry system for managing check registration and profile composition |
| pkg/evaluate/categories.go | Category specifications with ordering and default profile assignments |
| pkg/evaluate/*.go (multiple) | Added init() functions to register checks with the new registry |
| pkg/evaluate/evaluate.go | Simplified to delegate to new evaluator system |
| pkg/evaluate/evaluate_test.go | New tests for profile registration and execution |
| pkg/cli/parse.go | Updated to support --profile flag and removed auto-escape feature |
| pkg/cli/banner.go | Updated usage documentation to reflect new profile options |
| conf/evaluate_conf.go | Added Volcano Engine cloud provider metadata API |
| README.md | Updated documentation with new profile-based usage examples |
Comments suppressed due to low confidence (1)
pkg/evaluate/service_discorvery_dns.go:1
- File name contains a typo: 'discorvery' should be 'discovery'. The file should be renamed from
service_discorvery_dns.gotoservice_discovery_dns.go.
package evaluate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // if Args["auto-escape"].(bool) { | ||
| // plugin.RunSingleTask("auto-escape") | ||
| // return true | ||
| // } | ||
|
|
There was a problem hiding this comment.
Commented-out code should be removed rather than left in the codebase. If this functionality may be needed in the future, it should be tracked in version control history or an issue tracker.
| // if Args["auto-escape"].(bool) { | |
| // plugin.RunSingleTask("auto-escape") | |
| // return true | |
| // } |
No description provided.